chore(deps): Set the correct postgres version everywhere and make failing checks neutral#178
Merged
crankynetman merged 2 commits intomainfrom Nov 12, 2025
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c924aff |
…isn't supported until either libraries get fixed or we upgrade to django 5.2 or newer.
crankynetman
changed the title
crankynetman
deleted the
topic/chriscummings/postgres-version-this-time-with-feeling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't set the postgres version in the makefile and that does seem to matter. I'm not sure why we set it in two places, but it seems it was done on purpose.
Also let's make the "next python version" checks neutral checks since we know that py3.13 isn't supported until either libraries get fixed or we upgrade to django 5.2 or newer.
Note: Until this is merged into main, checks for 3.13 on push and pull_request will fail I think.